Hello, while going through the install script I noticed the following lines in the _quickstats()
function:
LOCALE=en_GB.UTF-8
LANG=lang_en
sed -i "s/LOCALE/${locale}/g" /srv/rutorrent/home/inc/localize.php
sed -i "s/LANG/${lang}/g" /srv/rutorrent/home/inc/localize.php
Two things caught my attention:
-
The locale en_GB.UTF-8, while everywhere else it is en_US.UTF-8;
-
The variable substitution, which doesn’t refer to the just defined vars because the case doesn’t match; e.g.:
[neitsab@my-pc ~]$ LOCALE=en_GB.UTF-8 [neitsab@my-pc ~]$ echo ${locale} [neitsab@my-pc ~]$ echo ${LOCALE} en_GB.UTF-8
So I believe those two sed
expressions should be changed to use uppercase LANG
and LOCALE
, and GB
to US
as is custom in the rest of the script.
(Sidenote: what is the rationale behind forcing a locale? Ease bug report/harmonize user installations?)
By the way, is this the preferred way to report bugs at Quickbox? Or is it over the Quicklab repo?
Thanks for your work and community welcoming.